Skip to content

Fix false positive lint error from no_implicit_prelude attr #141892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Jun 2, 2025

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2025
@chenyukang chenyukang force-pushed the yukang-fix-141785-extern-crate branch from 9d5bb70 to 7167e7c Compare June 2, 2025 09:49
@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 7167e7c has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 2, 2025
…n-crate, r=petrochenkov

Fix false positive lint error from no_implicit_prelude attr

Fixes rust-lang#141785

r? ``@petrochenkov``
bors added a commit that referenced this pull request Jun 2, 2025
Rollup of 6 pull requests

Successful merges:

 - #141884 (allow macro_use as first segment)
 - #141885 ([RTE-484] Update SGX maintainers)
 - #141892 (Fix false positive lint error from no_implicit_prelude attr)
 - #141894 (rustc-dev-guide subtree update)
 - #141895 (tshepang has a new email)
 - #141897 (Fix citool tests when executed locally)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1931272 into rust-lang:master Jun 2, 2025
9 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 2, 2025
rust-timer added a commit that referenced this pull request Jun 2, 2025
Rollup merge of #141892 - chenyukang:yukang-fix-141785-extern-crate, r=petrochenkov

Fix false positive lint error from no_implicit_prelude attr

Fixes #141785

r? `@petrochenkov`
jieyouxu pushed a commit to jieyouxu/rustc-dev-guide that referenced this pull request Jun 3, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#141884 (allow macro_use as first segment)
 - rust-lang/rust#141885 ([RTE-484] Update SGX maintainers)
 - rust-lang/rust#141892 (Fix false positive lint error from no_implicit_prelude attr)
 - rust-lang/rust#141894 (rustc-dev-guide subtree update)
 - rust-lang/rust#141895 (tshepang has a new email)
 - rust-lang/rust#141897 (Fix citool tests when executed locally)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive unused_extern_crates
4 participants