Skip to content

Ignore /build even if it’s a symlink. #14545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ignore /build even if it’s a symlink. #14545

wants to merge 1 commit into from

Conversation

SimonSapin
Copy link
Contributor

No description provided.

@alexcrichton
Copy link
Member

Doesn't this ignore all directories named build, regardless at what level of the tree they're in?

@lilyball
Copy link
Contributor

@alexcrichton Yes. If you only want to ignore build at the current level, you should use /build.

@SimonSapin
Copy link
Contributor Author

I’m not sure. I made almost the same change in #12319, but it was removed in #14512.

@alexcrichton
Copy link
Member

Perhaps #14512 should have reverted the other? Could we ignore /build but not build/ to ignore top-level build directories but not folders named build?

@SimonSapin SimonSapin mentioned this pull request May 30, 2014
Merged
@SimonSapin
Copy link
Contributor Author

@alexcrichton I’m fine with #14546, if you prefer that.

@alexcrichton
Copy link
Member

Closing in favor of #14546, thanks!

bors added a commit that referenced this pull request May 30, 2014
@bors
auto merge of #14546 : SimonSapin/rust/patch-13, r=alexcrichton
7e461ea 
CC @alexcrichton
Closes #14545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonSapin @alexcrichton @lilyball