Remove unnecessary allocations / clones during method lookup #14563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| continue; | ||
| } else { | ||
| merged.push(candidate_a.clone()); | ||
| candidates_same |
There was a problem hiding this comment.
Can you skip the local variable and just "return" the match directly?
By dropping the intermediate vector that holds the relevant candidates including duplicates and directly building the vector that has the duplicates removed we can eliminate quite a few allocations. This reduces the times for type checking by 5-10% (measured with libstd, libsyntax and librustc).
bors
added a commit
that referenced
this pull request
May 31, 2014
By dropping the intermediate vector that holds the relevant candidates including duplicates and directly building the vector that has the duplicates removed we can eliminate quite a few allocations. This reduces the times for type checking by 5-10% (measured with libstd, libsyntax and librustc).
|
Nice wins! |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2025
This PR enables to the canonicalization of issue links in triagebot. Documentation pending at rust-lang/rust-forge#825 changelog: add `[canonicalize-issue-links]` in `triagebot.toml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By dropping the intermediate vector that holds the relevant candidates
including duplicates and directly building the vector that has the
duplicates removed we can eliminate quite a few allocations. This
reduces the times for type checking by 5-10% (measured with libstd,
libsyntax and librustc).