Skip to content

Change to_str().to_string() to just to_str() #14667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2014
Merged

Change to_str().to_string() to just to_str() #14667

merged 1 commit into from
Jun 6, 2014

Conversation

aochagavia
Copy link
Contributor

No description provided.

@aochagavia
Copy link
Contributor Author

It seems that to_str() now returns a &'static str instead of a String. However, the documentation says the contrary: http://static.rust-lang.org/doc/master/std/to_str/trait.ToStr.html

@aochagavia
Copy link
Contributor Author

Does anybody know what is going on here?

@huonw
Copy link
Member

huonw commented Jun 6, 2014

No, it's just some type that defines it's own to_str method that returns &'static str, i.e. not part of the trait.

@aochagavia
Copy link
Contributor Author

Got it. I have fixed it and added a comment explaining this fact.

bors added a commit that referenced this pull request Jun 6, 2014
@bors bors closed this Jun 6, 2014
@bors bors merged commit 501b904 into rust-lang:master Jun 6, 2014
@aochagavia aochagavia deleted the pr2 branch June 6, 2014 13:16
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
…type, r=HKalbasi

Handle nested types in `unwrap_result_return_type` assist

Fixes rust-lang/rust-analyzer#14496
flip1995 added a commit to flip1995/rust that referenced this pull request Apr 22, 2025
Out of cycle sync, as the sync to Rust failed again and resolving
conflicts there is awkward.

r? @ghost

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants