Remove outdated info about nested block comments. Fixes #14767 #14800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Comments in Rust code follow the general C++ style of line and block-comment forms, | ||
| with no nesting of block-comment delimiters. | ||
| Comments in Rust code follow the general C++ style of line and block-comment forms. | ||
| Nested comments are supported. |
There was a problem hiding this comment.
Could you tweak this a bit to say that nested block comments are supported?
bors
added a commit
that referenced
this pull request
Jun 12, 2014
According to #14767 and the grammar right above this documentation, nested comments are supported.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…=Veykril Expand more single ident macro calls upon item collection Addresses rust-lang/rust-analyzer#14781 (comment) I believe this (almost) brings the number of unresolved names back to pre-rust-lang#14781: |r-a version|`analysis-stats compiler/rustc` (rust-lang/rust@69fef92) | |---|---| |pre-rust-lang#14781 (b069eb7) | exprs: 2747778, ??ty: 122236 (4%), ?ty: 107826 (3%), !ty: 728 | | rust-lang#14781 (a7944a9) | exprs: 2713080, ??ty: 139651 (5%), ?ty: 114444 (4%), !ty: 730 | | with this fix | exprs: 2747871, ??ty: 122237 (4%), ?ty: 108171 (3%), !ty: 676 | (I haven't investigated on the increase in some numbers but hopefully not too much of a problem) This is only a temporary solution. The core problem is that we haven't fully implemented the textual scope of legacy macros. For example, we *have been* failing to resolve `foo` in the following snippet, even before rust-lang#14781 or after this patch. As noted in a FIXME, we need a way to resolve names in textual scope without eager expansion during item collection. ```rust //- /main.rs crate:main deps:lib lib::mk_foo!(); const A: i32 = foo!(); //^^^^^^ unresolved-macro-call //- /lib.rs crate:lib #[macro_export] macro_rules! mk_foo { () => { macro_rules! foo { () => { 42 } } } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #14767 and the grammar right above this documentation, nested comments are supported.