Skip to content

Guide: Remove unused tuple struct #16198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2014

Conversation

cakebaker
Copy link
Contributor

No description provided.

@steveklabnik
Copy link
Member

r+=me, thanks. I adapted the code from the tutorial, and changed it a bit.

@lilyball
Copy link
Contributor

lilyball commented Aug 2, 2014

@steveklabnik: To approve something, it's just r+, or it's r=me, and it has to go as a comment on the final commit rather than on the PR itself.

@steveklabnik
Copy link
Member

@kballard I wasn't sure that I actually have permission to merge things. If I do, then I will actually do it.

@lilyball
Copy link
Contributor

lilyball commented Aug 2, 2014

Ah ok. I thought the r+=me was a confused attempt at saying r+.

@steveklabnik
Copy link
Member

Yeah, it's more of a 'hey, i checked this out and i approve.'

bors added a commit that referenced this pull request Aug 3, 2014
@bors bors closed this Aug 3, 2014
@bors bors merged commit 867d8e6 into rust-lang:master Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants