libunicode: optimize char functions for ascii characters #16670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pub fn is_alphabetic(c: char) -> bool { | ||
| ('\x41' <= c && c <= '\x5a') | ||
| || ('\x61' <= c && c <= '\x7a') | ||
| || (c > '\x7f' && derived_property::Alphabetic(c)) |
There was a problem hiding this comment.
Why are you using hex escapes instead of the recognizable literal characters?
|
These conditionals might read easier as |
|
Ok, I amended the patch, now using match expressions. Also specialized is_upper/lowercase in the same way. For my personal usecase (using str.words() on a ~15M ascii file), it went from ~18% in tables::White_Space to ~7% in u_char::is_whitespace which is a clear win. The generated assembly is just ~20 instructions, so it should be fine. But I’m by far no pro when it comes to reading assembly :-D |
bors
added a commit
that referenced
this pull request
Aug 23, 2014
I was doing a lot of parsing ascii strings, and the generic bsearch functions in `tables.rs` came up very high in the profile. This should avoid calling those functions for simple ASCII range chars.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2024
…kril Document nvim 0.10 `inlay_hint` It took me a few hours to figure out how to enable inlay type hints on Nvim 0.10 with `lspconfig`. `rustaceanvim` has already dropped support for them (mrcjkb/rustaceanvim#46 (comment)) and most other plugins, like `rust-tools`, are depreciated in favor of `rustaceanvim`. This PR documents how to enable the inlay hints on Neovim 0.10 and later. I've tested this and changing the `on_attach` function is the only step that is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing a lot of parsing ascii strings, and the generic bsearch functions in
tables.rscame up very high in the profile.This should avoid calling those functions for simple ASCII range chars.