libcore: Simplify Enumerate, Zip::next_back #16728
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ExactSize::len() and defer to its decisions about overly defensive assertions. Remove the length double-check and simply put a failure case if the Zip finds an uneven end in .next_back(). Fixing this up since I think I wrote this, and it's been known to confuse rusties (PR#15886).
| assert!(a_sz == b_sz); | ||
| let a_sz = self.a.len(); | ||
| let b_sz = self.b.len(); | ||
| if a_sz != b_sz { |
There was a problem hiding this comment.
Rather than two checks here, couldn't you just do one cmp?
There was a problem hiding this comment.
Actually, strictly speaking you can just have the a_sz > b_sz check, because in the else branch if a_sz = b_sz, then the range is empty and the loop doesn't run.
Not sure what's the most efficient/readable here.
There was a problem hiding this comment.
Thanks for the input, I don't know exactly either. But the evening out step should only happen once, and that's why I wanted a single comparison to exclude it.
|
👍 this significantly improves the code quality. |
bors
added a commit
that referenced
this pull request
Aug 24, 2014
Use ExactSize::len() and defer to its decisions about overly defensive assertions. Remove the length double-check and simply put a failure case if the Zip finds an uneven end in .next_back(). Fixing this up since I think I wrote this, and it's been known to confuse rusties (PR #15886).
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 3, 2024
minor: Move span stuff around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ExactSize::len() and defer to its decisions about overly defensive
assertions. Remove the length double-check and simply put a failure
case if the Zip finds an uneven end in .next_back().
Fixing this up since I think I wrote this, and it's been known to
confuse rusties (PR #15886).