from_str has an impl for uint, not Option<uint> #17366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Sep 23, 2014
See: http://doc.rust-lang.org/std/from_str/trait.FromStr.html ``` let input_num = from_str::<Option<uint>>("5"); ``` ``` <anon>:2:21: 2:45 error: failed to find an implementation of trait std::from_str::FromStr for core::option::Option<uint> <anon>:2 let input_num = from_str::<Option<uint>>("5"); ^~~~~~~~~~~~~~~~~~~~~~~~ ```
|
I just realized that that would have been time travel, this PR is old! Sorry I missed it :/ |
| @@ -2153,14 +2153,10 @@ In this case, we say `x` is a `uint` explicitly, so Rust is able to properly | |||
| tell `random()` what to generate. In a similar fashion, both of these work: | |||
|
|
|||
| ```{rust,ignore} | |||
There was a problem hiding this comment.
Why aren't these lines being tested in the first place?
There was a problem hiding this comment.
Unsure. I have a blanket to-do to go through the guide and check that each one of them really needs to be ignored, but this one seems like a good candidate to be not ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: http://doc.rust-lang.org/std/from_str/trait.FromStr.html