Skip to content

vim: Fix :RustRun when cwd has a space in it #18247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2014
Merged

vim: Fix :RustRun when cwd has a space in it #18247

merged 1 commit into from
Nov 4, 2014

Conversation

lilyball
Copy link
Contributor

@chris-morgan
Copy link
Member

LGTM.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Nov 4, 2014
@alexcrichton
rollup merge of rust-lang#18247 : kballard/vim_rust_run_cwd_space
b8e2eb7
@bors bors merged commit c582974 into rust-lang:master Nov 4, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Oct 17, 2024
@bors
Auto merge of rust-lang#18247 - jhgg:lsp/fix-something-to-resolve, r=…
3e42fc5 
…Veykril

lsp: fix completion_item something_to_resolve not being a latch to true

while looking at rust-lang#18245 i noticed that `something_to_resolve` could technically flap between true -> false if some subsequent fields that were requested to be resolved were empty.

this fixes that by using `|=` instead of `=` when assigning to `something_to_resolve` which will prevent it from going back to false once set.

although some cases it's simply assigning to `true` i opted to continue to use `|=` there for uniformity sake. but happy to change those back to `=`'s.

cc `@SomeoneToIgnore`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilyball @chris-morgan @alexcrichton @bors