Paren sugar #18622
Closed
Paren sugar #18622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…,C>`. These paths also bind anonymous regions (or will, once HRTB is fully working). Fixes rust-lang#18423.
| @@ -1838,6 +1838,14 @@ pub fn mk_slice(cx: &ctxt, r: Region, tm: mt) -> t { | |||
|
|
|||
| pub fn mk_tup(cx: &ctxt, ts: Vec<t>) -> t { mk_t(cx, ty_tup(ts)) } | |||
|
|
|||
| pub fn mk_tup_or_nil(cx: &ctxt, ts: Vec<t>) -> t { | |||
| if ts.len() == 0 { | |||
| ty::mk_nil() | |||
There was a problem hiding this comment.
We ought to investigate the cost of interning ty_tup(Vec::new()).
Actually, one idea I had (interning everything referenced by Ty in the arena) would result in ty_tup(&'tcx [Ty<'tcx>]) which allows a statically declared ty_nil as ty_tup(&[]).
|
Closing in favor of #18630, which includes these commits. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Dec 11, 2024
fix: Fix parsing of dyn T in generic arg on 2015 edition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the
Foo()paren sugar more uniformly as envisioned by the RFC.r? @pcwalton
Fixes #17703 (among other things).