-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Move rustup to the combined installer #20452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@erickt The ability to pull from the archives will be temporarily broken during the transition to the combined installer because it has a different name. |
@brson: no worries! it'll be way better to have this landed :) |
Just FYI, I tried the combined nightly (gotten from https://static.rust-lang.org/dist/rust-combined-nightly-x86_64-unknown-linux-gnu.tar.gz ) and it installed the HTML documentation in a directory that was not world-readable. |
Tidy failure: line exceeds 100 characters. |
@SiegeLord presumably that directory was /usr/local/share/doc/rust? What's the documentation directory on your system, and what system is it? |
@brson No, it was the
|
@SeigeLord perhaps the problem is that the installer is installing the docs using 'cp' instead of 'install', so the files end up with the wrong permissions. |
@SiegeLord I see the same permissions problem here. I only tested in by listing the directory, not actually reading the files. Thanks for bringing it to my attention. |
Move rustup to the combined installer Reviewed-by: brson
Move rustup to the combined installer Reviewed-by: brson
This changes rustup to use the combined installer instead of downloading both rust and cargo. Temporarily it loses the ability to not install cargo, but sometime soon I'll upgrade rust-installer to support selecting components.
It also disables verbose tarball extraction because it is very noisy with the volume of docs.
Supersedes #19927
I've already uploaded to s3.