Change & pat to only work with &T, and &mut with &mut T.
#20554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
| let &_ = bar; | ||
| let &mut _ //~ ERROR expected `&int`, found `&mut _` | ||
| = bar; | ||
| } |
There was a problem hiding this comment.
Could you add a test to check that after let &mut x = ..., x is not actually mutable (unless it is let mut &mut x, I guess).
|
r=me with the extra test |
This implements RFC 179 by making the pattern `&<pat>` require matching
against a variable of type `&T`, and introducing the pattern `&mut
<pat>` which only works with variables of type `&mut T`.
The pattern `&mut x` currently parses as `&(mut x)` i.e. a pattern match
through a `&T` or a `&mut T` that binds the variable `x` to have type
`T` and to be mutable. This should be rewritten as follows, for example,
for &mut x in slice.iter() {
becomes
for &x in slice.iter() {
let mut x = x;
Due to this, this is a
[breaking-change]
Closes rust-lang#20496.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 5, 2015
Conflicts: src/librustc_typeck/check/_match.rs
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 6, 2015
Conflicts: src/librustc_typeck/check/_match.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements RFC 179 by making the pattern
&<pat>require matchingagainst a variable of type
&T, and introducing the pattern&mut <pat>which only works with variables of type&mut T.The pattern
&mut xcurrently parses as&(mut x)i.e. a pattern matchthrough a
&Tor a&mut Tthat binds the variablexto have typeTand to be mutable. This should be rewritten as follows, for example,becomes
Due to this, this is a
[breaking-change]
Closes #20496.