Implement RFC 580 #22483
Closed
Implement RFC 580 #22483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static INITIAL_CAPACITY: usize = 7; // 2^3 - 1 | ||
| static MINIMUM_CAPACITY: usize = 1; // 2 - 1 | ||
|
|
||
| /// `RingBuf` is a circular buffer, which can be used as a double-ended queue efficiently. | ||
| /// `VecDeque` is a circular buffer, which can be used as a double-ended queue efficiently. |
There was a problem hiding this comment.
Could you add the word "ring buffer" to the documentation so you can find this collection if you want something akin to a ring buffer?
|
Needs a rebase, sorry. |
aturon
force-pushed
the
rfc-580
branch
2 times, most recently
from
0d303c9 to
540b8db
Compare
This commit implements RFC 580 by renaming: * DList -> LinkedList * Bitv -> BitVec * BitvSet -> BitSet * RingBuf -> VecDeque More details are in [the RFC](rust-lang/rfcs#580) [breaking-change]
|
Rebased and ready for review. |
|
Merged into #22491 |
| //! | Bitv | O(1) | O(n-i)* | O(n-i) | O(m)* | O(n-i) | | ||
| //! | VecDeque | O(1) | O(min(i, n-i))* | O(min(i, n-i)) | O(m)* | O(min(i, n-i)) | | ||
| //! | LinkedList | O(min(i, n-i)) | O(min(i, n-i)) | O(min(i, n-i)) | O(1) | O(min(i, n-i)) | | ||
| //! | BitVec | O(1) | O(n-i)* | O(n-i) | O(m)* | O(n-i) | |
There was a problem hiding this comment.
RIP nice computer-generated ASCII table 😭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements RFC 580 by renaming:
More details are in the RFC
[breaking-change]
r? @gankro
cc @CloudiDust