Skip to content

Tuple macro cleanup #23395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2015
Merged

Tuple macro cleanup #23395

merged 2 commits into from
Mar 16, 2015

Conversation

bluss
Copy link
Member

@bluss bluss commented Mar 15, 2015

Remove the unused parts of the tuple macro in libcore (for val0 and similar removed methods). Also adjust the module docs accordingly.

Ulrik Sverdrup added 2 commits March 15, 2015 18:16
Remove mention of removed methods `.val0` etc.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Collaborator

bors commented Mar 15, 2015

@bors r=alexcrichton 880b8c5

@bors
Copy link
Collaborator

bors commented Mar 15, 2015

⌛ Testing commit 880b8c5 with merge 41efba6...

bors added a commit that referenced this pull request Mar 15, 2015
Remove the unused parts of the tuple macro in libcore (for `val0` and similar removed methods). Also adjust the module docs accordingly.
@bors
Copy link
Collaborator

bors commented Mar 16, 2015

💔 Test failed - auto-linux-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Mar 15, 2015 at 6:23 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-linux-32-opt
http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4079


Reply to this email directly or view it on GitHub
#23395 (comment).

bors added a commit that referenced this pull request Mar 16, 2015
Remove the unused parts of the tuple macro in libcore (for `val0` and similar removed methods). Also adjust the module docs accordingly.
@bors
Copy link
Collaborator

bors commented Mar 16, 2015

⌛ Testing commit 880b8c5 with merge cc78919...

@bors bors merged commit 880b8c5 into rust-lang:master Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants