-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Incoming #2576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't seem to show up anywhere else in the test suite, even though it's supposed to be legal.
And replace trans::common::block_parent with option<block>. To handle the recursive self-reference in the block_ class, I had to add a newtype-like enum "block" which is equivalent to @block_ -- which due to an interaction with borrowck, resulted in having to change a few functions in trans::base to take their block argument in ++ mode, irritatingly enough (but not that irritatingly, since we're supposed to get rid of modes).
… some PointerCasts.
This allows destructors to be inlined, which is necessary since classes can have both ty params and destructors.
(basically a stripped-down version of comm, and a "driver" that constructs a new port)
This lets us pass them to generic functions.
pcwalton
added a commit
that referenced
this pull request
Jun 13, 2012
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Oct 4, 2022
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.