Skip to content

Correctly detect reassignments to the interior of matched structs/tuples #27011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2015
Merged

Correctly detect reassignments to the interior of matched structs/tuples #27011

merged 1 commit into from
Jul 13, 2015
+21 −1

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Jul 13, 2015

If we match a whole struct or tuple, the "field" for the reassignment
checker will be "None" which means that mutating any field should count
as a reassignment.

Fixes #26996.

@dotdash
Correctly detect reassignments to the interior of matched structs/tuples
043d7b5 
If we match a whole struct or tuple, the "field" for the reassignment
checker will be "None" which means that mutating any field should count
as a reassignment.

Fixes rust-lang#26996.
@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@luqmana luqmana assigned luqmana and unassigned brson Jul 13, 2015
@pnkfelix
Copy link
Member

(my preference would be to stop using an Option to represent the scenario here, since I find it quite the meaning of None here to be somewhat less than intuitive. But I suspect a lot of this code is going to be rewritten anyway assuming we go through with our planned switch to a MIR, so I won't block this change based on that personal preference.)

@pnkfelix
Copy link
Member

@bors r+ 043d7b5

@luqmana
Copy link
Member

luqmana commented Jul 13, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 13, 2015

📌 Commit 043d7b5 has been approved by luqmana

@bors
Copy link
Collaborator

bors commented Jul 13, 2015

⌛ Testing commit 043d7b5 with merge df39a92...

bors added a commit that referenced this pull request Jul 13, 2015
@bors
Auto merge of #27011 - dotdash:issue-26996, r=luqmana
df39a92 
If we match a whole struct or tuple, the "field" for the reassignment
checker will be "None" which means that mutating any field should count
as a reassignment.

Fixes #26996.
@bors
Copy link
Collaborator

bors commented Jul 13, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit 043d7b5 into rust-lang:master Jul 13, 2015
@dotdash dotdash deleted the issue-26996 branch July 27, 2015 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@luqmana luqmana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dotdash @rust-highfive @pnkfelix @luqmana @bors @brson