std: Be resilient to failure in pthread_getattr_np #27073
Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @dwrensha |
|
\o/ |
|
This LGTM as a hack until we finally get LLVM to implement stack probes (please, we’ve been waiting for quite a while now!). |
|
r? @brson |
|
@bors r+ |
|
📌 Commit ba19824 has been approved by |
|
⌛ Testing commit ba19824 with merge 85f9fcb... |
|
💔 Test failed - auto-mac-64-opt |
alexcrichton
force-pushed
the
less-proc-fs
branch
from
ba19824 to
cfe464b
Compare
|
@bors: r=brson cfe464b |
|
⌛ Testing commit cfe464b with merge 8420563... |
|
💔 Test failed - auto-win-gnu-32-nopt-t |
alexcrichton
force-pushed
the
less-proc-fs
branch
from
cfe464b to
e966eed
Compare
|
@bors: r=brson On Mon, Jul 20, 2015 at 8:19 PM, bors [email protected] wrote:
|
|
📌 Commit e966eed has been approved by |
|
⌛ Testing commit e966eed with merge 4ff7780... |
|
💔 Test failed - auto-linux-64-x-android-t |
This can fail on linux for various reasons, such as the /proc filesystem not being mounted. There are already many cases where we can't set up stack guards, so just don't worry about this case and communicate that no guard was enabled. I've confirmed that this allows the compiler to run in a chroot without /proc mounted. Closes rust-lang#22642
alexcrichton
force-pushed
the
less-proc-fs
branch
from
e966eed to
d68b152
Compare
|
@bors: r=brson On Tue, Jul 21, 2015 at 1:26 AM, bors [email protected] wrote:
|
|
📌 Commit d68b152 has been approved by |
This can fail on linux for various reasons, such as the /proc filesystem not being mounted. There are already many cases where we can't set up stack guards, so just don't worry about this case and communicate that no guard was enabled. I've confirmed that this allows the compiler to run in a chroot without /proc mounted. Closes #22642
|
Thank you! |
This can fail on linux for various reasons, such as the /proc filesystem not
being mounted. There are already many cases where we can't set up stack guards,
so just don't worry about this case and communicate that no guard was enabled.
I've confirmed that this allows the compiler to run in a chroot without /proc
mounted.
Closes #22642