Skip to content

Assign proper span to range expression #27203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2015
Merged

Assign proper span to range expression #27203

merged 1 commit into from
Jul 23, 2015

Conversation

marcusklaas
Copy link
Contributor

Right trims the span for certain range expressions.

Closes #27162.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ b36d107

Thanks!

bors added a commit that referenced this pull request Jul 23, 2015
Right trims the span for certain range expressions.

Closes #27162.
@bors
Copy link
Collaborator

bors commented Jul 23, 2015

⌛ Testing commit b36d107 with merge eb96fb6...

@bors
Copy link
Collaborator

bors commented Jul 23, 2015

💔 Test failed - auto-linux-32-opt

@alexcrichton
Copy link
Member

@bors: retry

cc @gankro, that failure seems... worrying

failures:

---- btree::map::test_iter stdout ----
    thread 'btree::map::test_iter' panicked at 'assertion failed: `(left == right)` (left: `(9222, 9222)`, right: `(9216, 9216)`)', ../src/libcollectionstest/btree/map.rs:88



failures:
    btree::map::test_iter

test result: FAILED. 710 passed; 1 failed; 0 ignored; 0 measured

@bors
Copy link
Collaborator

bors commented Jul 23, 2015

⌛ Testing commit b36d107 with merge 2e5b165...

bors added a commit that referenced this pull request Jul 23, 2015
Right trims the span for certain range expressions.

Closes #27162.
@alexcrichton
Copy link
Member

I think I confused homu by accident, but all the tests passes so merging manually

@alexcrichton alexcrichton merged commit b36d107 into rust-lang:master Jul 23, 2015
@marcusklaas marcusklaas deleted the fix-range-span branch July 23, 2015 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants