Skip to content

Add E0417, E0424, E0425, E0426, E0430, E0431 and E0432 error explanations #27230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 27, 2015

Conversation

GuillaumeGomez
Copy link
Member

Part of #24407.
cc @Manishearth

@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez GuillaumeGomez changed the title Add E0417 error explanation Add E0417 and E0424 error explanations Jul 23, 2015
}
```

Compiler needs to know the pattern value at compile's time, which is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler needs to know the value of the pattern at compile time,

```

The compiler needs to know the value of the pattern at compile time,
which is not possible with a `static` variable. Please verify that the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: saying "is not possible" may be re-opening a can of worms by implicitly inviting back those who were arguing, back when we first split up the two forms, that the static / const distinction was unnecessary.

I would prefer something like:

The compiler needs to know the value of the pattern at compile time; compile-time patterns can defined via const or enum items. Please verify that the identifier is spelled correctly, and if so, use a const instead of static to define it.
Example:
...

@GuillaumeGomez GuillaumeGomez changed the title Add E0417 and E0424 error explanations Add E0417, E0424 and E0430 error explanations Jul 24, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0417, E0424 and E0430 error explanations Add E0417, E0424, E0430 and E0431 error explanations Jul 24, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0417, E0424, E0430 and E0431 error explanations Add E0417, E0424, E0430, E0431 and E0432 error explanations Jul 24, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0417, E0424, E0430, E0431 and E0432 error explanations Add E0417, E0424, E0426, E0430, E0431 and E0432 error explanations Jul 24, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0417, E0424, E0426, E0430, E0431 and E0432 error explanations Add E0417, E0424, E0425, E0426, E0430, E0431 and E0432 error explanations Jul 24, 2015
}
```

Please check if the method's argument list should have contained self,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self, &self or &mut self.

@brson
Copy link
Contributor

brson commented Jul 27, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 27, 2015

📌 Commit fc65f55 has been approved by brson

bors added a commit that referenced this pull request Jul 27, 2015
@bors
Copy link
Collaborator

bors commented Jul 27, 2015

⌛ Testing commit fc65f55 with merge 3e6b03c...

@bors bors merged commit fc65f55 into rust-lang:master Jul 27, 2015
@GuillaumeGomez GuillaumeGomez deleted the patch-1 branch July 27, 2015 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants