Assorted diagnostics improvements #27313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
r- I want the style guide updated too. I'm gonna send a PR against nagisa's branch for that. |
|
Actually, scratch that r-. There's no document to place such guidelines on. |
|
☔ The latest upstream changes (presumably #27234) made this pull request unmergeable. Please resolve the merge conflicts. |
Mostly by splitting error messages into proper pairs of errors and helps
nagisa
force-pushed
the
illegal-to-invalid
branch
from
b64aa67 to
cca0ea7
Compare
|
Rebased. |
|
okay the other two commits are largely about this terminological shift from using the word "illegal" to using the word "invalid" I myself do not particularly mind, but I'm going to double check with some other team members to make sure everyone agrees that this is the right direction for us to go in. |
|
@bors r+ |
|
📌 Commit cca0ea7 has been approved by |
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 29, 2015
Improves diagnostics in various locations, namely: * A few error messages that orignally were a mix of an error message and suggestion how to fix it have been split up into two messages: an error and help/hint. * Never report “illegal”. Fixes rust-lang#27288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves diagnostics in various locations, namely: