Impl Eq/PartialEq on FnKind, improve docs #27857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
Nice! Could something similar be done for the |
|
Expr_ already implements Eq? As for the naming, I think ExprFoo is better there because the whole AST is glob-exported and imported everywhere. |
|
@bors r+ |
|
📌 Commit c03bf18 has been approved by |
|
⌛ Testing commit c03bf18 with merge 797d0ba... |
bors
added a commit
that referenced
this pull request
Aug 24, 2015
Since enums are namespaced now, should we also remove the `Fk` prefixes from `FnKind` and remove the reexport? (The reexport must be removed because otherwise it clashes with glob imports containing `ItemFn`). IMO writing `FnKind::Method` is much clearer than `FkMethod`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since enums are namespaced now, should we also remove the
Fkprefixes fromFnKindand remove the reexport? (The reexport must be removed because otherwise it clashes with glob imports containingItemFn). IMO writingFnKind::Methodis much clearer thanFkMethod.