Skip to content

Small syntax and formatting changes #28276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2015
Merged

Small syntax and formatting changes #28276

merged 1 commit into from
Sep 17, 2015

Conversation

id4ho
Copy link
Contributor

@id4ho id4ho commented Sep 6, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member

@bors r+ rollup

Thanks!

@bors
Copy link
Collaborator

bors commented Sep 7, 2015

📌 Commit 5c5cca5 has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Sep 7, 2015

⌛ Testing commit 5c5cca5 with merge 06748f2...

@bors
Copy link
Collaborator

bors commented Sep 7, 2015

💔 Test failed - auto-linux-64-nopt-t

@Manishearth
Copy link
Member

@bors r+ rollup

Er, what. That's a deterministic failure, but it can't possibly be triggered by this PR. O.o


---- [pretty] run-pass/std-sync-right-kind-impls.rs stdout ----

error: pretty-printed source does not typecheck
status: signal: 11
command: x86_64-unknown-linux-gnu/stage2/bin/rustc - -Zno-trans --target=x86_64-unknown-linux-gnu -L x86_64-unknown-linux-gnu/test/run-pass/ -L x86_64-unknown-linux-gnu/test/run-pass/std-sync-right-kind-impls.stage2-x86_64-unknown-linux-gnu.pretty.libaux --cfg rtopt -L x86_64-unknown-linux-gnu/rt
stdout:
------------------------------------------

------------------------------------------
stderr:
------------------------------------------

------------------------------------------

thread '[pretty] run-pass/std-sync-right-kind-impls.rs' panicked at 'explicit panic', /home/ubuntu/src/rust-buildbot/slave/auto-linux-64-nopt-t/build/src/compiletest/runtest.rs:1501

@alexcrichton I've been seeing some intermittents which are "deterministic" failures (should not be intermittent, should always pass or fail). This is the third case I've seen -- know anything about this? We might want to poke at this more, it's causing completely random failures.

@bors
Copy link
Collaborator

bors commented Sep 7, 2015

📌 Commit 5c5cca5 has been approved by Manishearth

@alexcrichton
Copy link
Member

Yes those happen from time to time, I've never been able to track down why

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Sep 15, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Sep 17, 2015
bors added a commit that referenced this pull request Sep 17, 2015
@bors bors merged commit 5c5cca5 into rust-lang:master Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants