Skip to content

resolve: don't speculatively create freevars when resolving #29547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2015
Merged

resolve: don't speculatively create freevars when resolving #29547

merged 1 commit into from
Nov 4, 2015

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Nov 3, 2015

resolve_identifier used to mark a variable as an upvar when used within a closure. However, the function is also used for the "unnecessary qualification" lint, which would mark paths whose last component had the same name as a local as upvars.

Fixes #29522

r? @eddyb

@eddyb
Copy link
Member

eddyb commented Nov 3, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 3, 2015

📌 Commit ca04855 has been approved by eddyb

@arielb1
Copy link
Contributor Author

arielb1 commented Nov 3, 2015

@bors r=eddyb

@bors
Copy link
Collaborator

bors commented Nov 3, 2015

📌 Commit ca04855 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Nov 4, 2015

⌛ Testing commit ca04855 with merge c340ea1...

bors added a commit that referenced this pull request Nov 4, 2015
@bors
Auto merge of #29547 - arielb1:speculative-upvar, r=eddyb
c340ea1 
`resolve_identifier` used to mark a variable as an upvar when used within a closure. However, the function is also used for the "unnecessary qualification" lint, which would mark paths whose last component had the same name as a local as upvars.

Fixes #29522 

r? @eddyb
@bors
Copy link
Collaborator

bors commented Nov 4, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit ca04855 into rust-lang:master Nov 4, 2015
@bors bors mentioned this pull request Nov 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect resolution with module paths and closure analysis
3 participants
@arielb1 @eddyb @bors