Skip to content

std: Update jemalloc version #30434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2015
Merged

Conversation

alexcrichton
Copy link
Member

It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

I... forget the reason that this bounced in the past, and it may have been fixed upstream, so I figured we should try again.

@steveklabnik
Copy link
Member

@bors: r+

Let's refresh our memories.

@bors
Copy link
Collaborator

bors commented Dec 17, 2015

📌 Commit aed7997 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Dec 19, 2015

⌛ Testing commit aed7997 with merge 8f431fa...

@bors
Copy link
Collaborator

bors commented Dec 19, 2015

💔 Test failed - auto-linux-64-nopt-t

@steveklabnik
Copy link
Member

@bors: retry

On Dec 19, 2015, 09:07 -0500, [email protected], wrote:

Test failed -auto-linux-64-nopt-t(http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/7421)


Reply to this email directly orview it on GitHub(#30434 (comment)).

@bors
Copy link
Collaborator

bors commented Dec 19, 2015

⌛ Testing commit aed7997 with merge a692b0d...

@bors
Copy link
Collaborator

bors commented Dec 19, 2015

💔 Test failed - auto-win-gnu-32-nopt-t

@sfackler
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Dec 20, 2015

⌛ Testing commit aed7997 with merge aa1075c...

@bors
Copy link
Collaborator

bors commented Dec 20, 2015

💔 Test failed - auto-win-gnu-32-nopt-t

@retep998
Copy link
Member

Both bot failures failed with the error code STATUS_RESOURCE_NOT_OWNED which is described as "{Application Error} The application attempted to release a resource it did not own. Click OK to terminate the application."

@alexcrichton
Copy link
Member Author

@bors: r+ c0b868e133744dd0d23849671d818f5dcefe25ad

@bors
Copy link
Collaborator

bors commented Dec 20, 2015

⌛ Testing commit c0b868e with merge 980c216...

@bors
Copy link
Collaborator

bors commented Dec 20, 2015

💔 Test failed - auto-win-gnu-64-opt

It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.
@alexcrichton
Copy link
Member Author

@bors: r+ 9929c24

@alexcrichton
Copy link
Member Author

We're currently passing --enable-lazy-lock, but I think that's fundamentally broken on Windows, so I've switched it to an explicit --disable-lazy-lock (as it's enabled by default on MinGW). Local tests show that the failing tests here pass with a jemalloc built under that configuration, so I'm hoping that enables this to finally land!

@bors
Copy link
Collaborator

bors commented Dec 21, 2015

⌛ Testing commit 9929c24 with merge 5d4efcb...

bors added a commit that referenced this pull request Dec 21, 2015
It's been awhile since we last updated jemalloc, and there's likely some bugs
that have been fixed since the last version we're using, so let's try to update
again.
@bors bors merged commit 9929c24 into rust-lang:master Dec 22, 2015
@alexcrichton alexcrichton deleted the update-jemalloc branch December 22, 2015 01:38
@alexcrichton
Copy link
Member Author

🌴

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Dec 22, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 20, 2016
We've been seeing a lot of timeouts in tests on the bots and investigation ended
pointing to jemalloc/jemalloc#315 as the culprit. Unfortunately it looks like
that doesn't seem to have a fix on the way soon, so let's temporarily downgrade
back to the previous version of jemalloc we were using (where rust-lang#30434 was the
most recent upgrade)
bors added a commit that referenced this pull request Jan 20, 2016
We've been seeing a lot of timeouts in tests on the bots and investigation ended
pointing to jemalloc/jemalloc#315 as the culprit. Unfortunately it looks like
that doesn't seem to have a fix on the way soon, so let's temporarily downgrade
back to the previous version of jemalloc we were using (where #30434 was the
most recent upgrade)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants