Skip to content

Fix ICE for lifetimes with semicolons #30813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2016

Conversation

fhahn
Copy link
Contributor

@fhahn fhahn commented Jan 10, 2016

This PR fixes an ICE due to an DiagnosticsBuilder not being canceld or emitted.

Ideally it would use Handler::cancel, but I did not manage to get a &mut reference to the diagnostics handler.

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned brson Jan 11, 2016
@nrc
Copy link
Member

nrc commented Jan 12, 2016

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 12, 2016

📌 Commit e61d21f has been approved by nrc

@bors
Copy link
Collaborator

bors commented Jan 13, 2016

⌛ Testing commit e61d21f with merge 6089eba...

bors added a commit that referenced this pull request Jan 13, 2016
This PR fixes an ICE due to an DiagnosticsBuilder not being canceld or emitted.

Ideally it would use `Handler::cancel`, but I did not manage to get a `&mut` reference to the diagnostics handler.
@bors bors merged commit e61d21f into rust-lang:master Jan 13, 2016
@fhahn fhahn deleted the fix-ice-semicolon-in-lifetime branch January 14, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants