Skip to content

Avoid gated feature checking unconfigured expanded items #32846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2016
Merged

Avoid gated feature checking unconfigured expanded items #32846

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ea66f3
Avoid gated feature checking unconfigured items
jseyfried Apr 8, 2016
417a6df
Add regression test
jseyfried Apr 8, 2016
5eb775e
Remove redundant gated feature checking pass
jseyfried Apr 9, 2016
86f069d
Remove redundant call to `expand_item_multi_modifier`
jseyfried Apr 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/libsyntax/ext/expand.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,7 @@ macro_rules! with_exts_frame {
// When we enter a module, record it, for the sake of `module!`
pub fn expand_item(it: P<ast::Item>, fld: &mut MacroExpander)
-> SmallVector<P<ast::Item>> {
let it = expand_item_multi_modifier(Annotatable::Item(it), fld);

expand_annotatable(it, fld)
expand_annotatable(Annotatable::Item(it), fld)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expand_annotatable begins with a call to expand_item_multi_modifier, which is idempotent (cf #21052).
This is unrelated to the rest of the PR.

.into_iter().map(|i| i.expect_item()).collect()
}

Expand Down