Skip to content

Show previous definition of duplicate impl item #33107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2016
Merged

Show previous definition of duplicate impl item #33107

merged 1 commit into from
Apr 26, 2016

Conversation

sanxiyn
Copy link
Member

@sanxiyn sanxiyn commented Apr 20, 2016

Fix #32971.

@rust-highfive
Copy link
Contributor

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Apr 21, 2016

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 21, 2016

📌 Commit f532685 has been approved by eddyb

@bors
Copy link
Collaborator

bors commented Apr 22, 2016

⌛ Testing commit f532685 with merge e8d44e5...

@bors
Copy link
Collaborator

bors commented Apr 22, 2016

💔 Test failed - auto-win-msvc-64-opt-mir

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Apr 22, 2016 at 8:39 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt-mir
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-mir/builds/410

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#33107 (comment)

@bors
Copy link
Collaborator

bors commented Apr 24, 2016

⌛ Testing commit f532685 with merge 9687604...

@bors
Copy link
Collaborator

bors commented Apr 24, 2016

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Sun, Apr 24, 2016 at 4:34 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-64-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/3925

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#33107 (comment)

@bors
Copy link
Collaborator

bors commented Apr 25, 2016

⌛ Testing commit f532685 with merge af43dbe...

@bors
Copy link
Collaborator

bors commented Apr 25, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 25, 2016
@Manishearth
Rollup merge of rust-lang#33107 - sanxiyn:prev-impl-item, r=eddyb
1bc30a5 
Show previous definition of duplicate impl item

Fix rust-lang#32971.
@Manishearth Manishearth mentioned this pull request Apr 25, 2016
Merged
bors added a commit that referenced this pull request Apr 25, 2016
@bors
Auto merge of #33204 - Manishearth:rollup, r=Manishearth
149cf77 
Rollup of 7 pull requests

- Successful merges: #33107, #33133, #33160, #33167, #33194, #33196, #33200
- Failed merges:
bors added a commit that referenced this pull request Apr 26, 2016
@bors
Auto merge of #33204 - Manishearth:rollup, r=Manishearth
41028de 
Rollup of 7 pull requests

- Successful merges: #33107, #33133, #33160, #33167, #33194, #33196, #33200
- Failed merges:
@bors bors merged commit f532685 into rust-lang:master Apr 26, 2016
@sanxiyn sanxiyn deleted the prev-impl-item branch April 26, 2016 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jroesch jroesch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sanxiyn @rust-highfive @eddyb @bors @alexcrichton @jroesch