Skip to content

Partial rewrite/expansion of Vec::truncate documentation. #34853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@frewsxcv
Copy link
Member Author

r? @GuillaumeGomez

/// # Examples
///
/// Truncating a five element vector to two elements:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"five element" -> "five elements"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "five element" is right. I asked my fiancée and she agreed with me. I wish I knew the exact English rules regarding this, but I don't. Probably something to do with plurality of attribute nouns.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, "five element" is accurate.

@GuillaumeGomez
Copy link
Member

Just a little typo when we're good! :)

@GuillaumeGomez
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 16, 2016

📌 Commit e2f5961 has been approved by GuillaumeGomez

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 17, 2016
…omez

Partial rewrite/expansion of `Vec::truncate` documentation.

None
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Jul 18, 2016
…omez

Partial rewrite/expansion of `Vec::truncate` documentation.

None
bors added a commit that referenced this pull request Jul 19, 2016
Rollup of 5 pull requests

- Successful merges: #34807, #34853, #34875, #34884, #34889
- Failed merges:
@bors bors merged commit e2f5961 into rust-lang:master Jul 19, 2016
@frewsxcv frewsxcv deleted the vec-truncate branch October 2, 2016 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants