Skip to content

dist-x86_64-linux: upgrade to CentOS 6 #41339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ishitatsuyuki
Copy link
Contributor

Now that CentOS 5 is EOL, we don't have to care too much about them. See #40848

i686? I don't care. jk, I'm planning to make them a crosstool-ng target so we don't need to care about multilib package miss or hard to obtain glibc versions.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@ishitatsuyuki
Copy link
Contributor Author

Build looks fine so far. Remove the commit when ready.

@aturon
Copy link
Member

aturon commented Apr 17, 2017

cc @alexcrichton @brson @TimNN @aidanhs

@aturon
Copy link
Member

aturon commented Apr 17, 2017

Note that, as discussed in #40848, should a move has implications for our glibc requirements.

@aturon aturon added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2017
@alexcrichton
Copy link
Member

I personally do not feel that we're ready to do this yet. We don't have an understanding of what the impact of this will be on downstream consumers of Rust. For now our builds are continuing to work, and I think we need to start thinking about moving to a higher glibc requirement for sure. I don't think there's much urgency though at this time.

My preferred method for dealing with this would be:

  • Make an announcement that we're considering increasing the minimum glibc requirement.
    • Clearly state what the impact of such a change would be
    • Ask others to test what version they have locally to see if it'll work
  • After awhile if everyone's on board announce that we're increasing the glibc requirement
  • Then merge a PR which increases the glibc requirement.

I'll also note that this PR is not currently passing tests (travis is failing) and this is likely to run afoul of #37874 on 32-bit which would necessitate compiling our own version of binutils.

@ishitatsuyuki
Copy link
Contributor Author

I have added openssl-devel which will hopefully fix the build. (It should fail on uploading artifacts, due to no IAM credentials anyway.) The binutils with devtoolset-6 is surely bleeding edge and I don't have concerns with that.

I will create a thread on internals.rlo to have some space for discussion.

When this propagates to beta it will surely break the i686 bootstrap, so I will file another PR for changing i686 to crosstool-ng (on decent distro) soon.

@alexcrichton
Copy link
Member

We should not need openssl-devel the intention is that we compile our own OpenSSL and use it locally. The build system manages this and has a pinned version of OpenSSL to compile against. We do not want to link against the system LLVM.

I would also personally wish to see i686 working before merging support for x86_64, although both I believe need to happen after a public discussion. A thread on internals sounds good to me.

@ishitatsuyuki
Copy link
Contributor Author

ishitatsuyuki commented Apr 18, 2017 via email

No more EOL support. Time to gain new compiler.
@ishitatsuyuki ishitatsuyuki force-pushed the docker-x86_64-upgrade branch from d2ed265 to a02e338 Compare April 18, 2017 06:19
@ishitatsuyuki
Copy link
Contributor Author

I have rebased and this can be merged at any time.

Here's the thread for discussion. Maybe putting this on newsletter will attract people who are using old glibc.

I'm currently working on i686 crosstool-ng config, stay tuned.

@alexcrichton
Copy link
Member

Ah yes, that makes sense for cargo-vendor. Also thanks for opening a thread on internals, I've left a comment there.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2017
@arielb1 arielb1 added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-core Relevant to the core team, which will review and decide on the PR/issue. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2017
@alexcrichton alexcrichton added T-tools and removed T-core Relevant to the core team, which will review and decide on the PR/issue. labels Apr 27, 2017
@ishitatsuyuki
Copy link
Contributor Author

I'm closing this again since I'm unable to get a good i686 image and there's some demand for glibc <2.12 (SLES 11 which is alive).

@ishitatsuyuki ishitatsuyuki deleted the docker-x86_64-upgrade branch May 18, 2017 08:42
@apiraino apiraino removed the S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants