std: Constify the bytes sent to Sha1::input #4327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are of course never going to modify the data, and this change allows us to accept data from to_bytes::IterBytes types.
|
Roughly, |
|
Not sure about those double parens, but I can't see why they would need to be there. I'll try removing them while testing this. |
|
Running try -- will merge when it's done. Thanks! |
ghost
assigned
|
Merged, thanks! |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 18, 2025
Automatic Rustup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Sha1 API takes the data to be hashed as &[u8]. This patch changes the type to &[const u8]. I'm not well-versed in the const semantics of Rust, but I imagine this is a reasonable thing to do, and this change makes the API compatible with to_bytes::IterBytes, which returns data in chunks of type &[const u8].
After making this change, 'make check' reports no failures for me.
(By the way, is there a reason for the double parentheses around the function argument lists in the Sha1 trait?)