Skip to content

Bump 'src/doc/book' git submodule. #43688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Aug 5, 2017

Primarily to pick up this change:

rust-lang/book#866

...to move this PR forward:

#43641

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 5, 2017

📌 Commit fd253b5 has been approved by carols10cents

@frewsxcv
Copy link
Member Author

frewsxcv commented Aug 5, 2017

@bors rollup

@bors
Copy link
Collaborator

bors commented Aug 5, 2017

⌛ Testing commit fd253b5e3bbb62892a9b2989f92594d285a2cbb5 with merge 25015a2bee498fa675f0632d35ed2fa147850962...

@kennytm
Copy link
Member

kennytm commented Aug 5, 2017

Tidy failure. Please update the Book again.

[00:04:05] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/convert_quotes.rs:48: line longer than 100 chars
[00:04:05] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/convert_quotes.rs:56: line longer than 100 chars
[00:04:05] tidy error: /checkout/src/doc/book/second-edition/tools/src/bin/convert_quotes.rs: incorrect license
[00:04:05] some tidy checks failed

@bors
Copy link
Collaborator

bors commented Aug 5, 2017

💔 Test failed - status-travis

@frewsxcv
Copy link
Member Author

frewsxcv commented Aug 5, 2017

Waiting on rust-lang/book#868

Primarily to pick up this change:

rust-lang/book#866

...to move this PR forward:

rust-lang#43641
@carols10cents
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Aug 5, 2017

📌 Commit abc76ae has been approved by carols10cents

@frewsxcv
Copy link
Member Author

frewsxcv commented Aug 5, 2017

Thanks for bumping. Haven't been at my computer for a while

@carols10cents
Copy link
Member

Sorry I wasn't at my computer for a while to merge the 2nd fix :)

@bors
Copy link
Collaborator

bors commented Aug 5, 2017

⌛ Testing commit abc76ae with merge dd1df35...

bors added a commit that referenced this pull request Aug 5, 2017
Bump 'src/doc/book' git submodule.

Primarily to pick up this change:

rust-lang/book#866

...to move this PR forward:

#43641
@bors
Copy link
Collaborator

bors commented Aug 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: carols10cents
Pushing dd1df35 to master...

@frewsxcv frewsxcv closed this Aug 6, 2017
@frewsxcv frewsxcv deleted the frewsxcv-bump-book branch August 6, 2017 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants