Range checking and miscellaneous fixes tin time library #4466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
%u flag takes a value in the range of 1-7. However value needs to be stored in tm.tm_wday between 0 and 6. %y takes a two-digit year value. Subtracting 1900_i32 from it is not needed.
This was requested in Issue #2350. New function match_digits_in_range added and used instead of match_digits wherever needed.
|
Thanks for fixing this! If you run |
|
Sorry for the delay in merging, I didn't see the long-lines fix right away. Thanks! |
catamorphism
added a commit
that referenced
this pull request
Jan 23, 2013
Range checking and miscellaneous fixes tin time library
|
Greatly appreciate the fix, but in the future if you could run |
|
Sorry for getting overly enthusiastic with merging the pull requests! I should have run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily adds range-checking that was requested in #2350. This is done using a helper function match_digits_in_range.
%u takes a day of the week in the range of 1-7. However it was previously treated identically to %w that takes a value in the range 0-6. Similarly, %y takes only a two-digit year and thereby subtracting 1900 from it is wrong. This is also fixed.
Further, I have also fixed the error messages in a few places where it was wrong.