Skip to content

Accept TyError in analyze_closure to avoid ICE #51723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2018

Conversation

estebank
Copy link
Contributor

Fix #51714.

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2018
@estebank
Copy link
Contributor Author

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Jun 23, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 23, 2018

📌 Commit 8ddf9a3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2018
@bors
Copy link
Collaborator

bors commented Jun 23, 2018

⌛ Testing commit 8ddf9a3 with merge ceda8a9fd6ee215a20ff841821a5a7e940cb05d1...

@bors
Copy link
Collaborator

bors commented Jun 23, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2018
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:30:01] curl: (6) Could not resolve host: static.rust-lang.org
[00:30:01] 
[00:30:01] spurious failure, trying again
[00:33:54] curl: (6) Could not resolve host: static.rust-lang.org
[00:33:54] failed to run: curl -s --retry 3 -Sf -o /tmp/tmplRirpo.sha256 https://static.rust-lang.org/dist/2018-05-10/rust-std-beta-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:33:54] Build completed unsuccessfully in 0:19:26
[00:33:54] Makefile:58: recipe for target 'check' failed
[00:33:54] make: *** [check] Error 1
[00:33:54] 
[00:33:54] 
[00:33:54] command did not execute successfully: "make" "check"
[00:33:54] 
[00:33:54] 
[00:33:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:33:54] Build completed unsuccessfully in 0:29:55
---
travis_time:end:0c281b50:start=1529736941454631538,finish=1529736941461548975,duration=6917437
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0351594a
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ef137f5
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:30:01] curl: (6) Could not resolve host: static.rust-lang.org
[00:30:01] 
[00:30:01] spurious failure, trying again
[00:33:54] curl: (6) Could not resolve host: static.rust-lang.org
[00:33:54] failed to run: curl -s --retry 3 -Sf -o /tmp/tmplRirpo.sha256 https://static.rust-lang.org/dist/2018-05-10/rust-std-beta-x86_64-unknown-linux-gnu.tar.gz.sha256
[00:33:54] Build completed unsuccessfully in 0:19:26
[00:33:54] Makefile:58: recipe for target 'check' failed
[00:33:54] make: *** [check] Error 1
[00:33:54] 
[00:33:54] 
[00:33:54] command did not execute successfully: "make" "check"
[00:33:54] 
[00:33:54] 
[00:33:54] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:33:54] Build completed unsuccessfully in 0:29:55
---
travis_time:end:0c281b50:start=1529736941454631538,finish=1529736941461548975,duration=6917437
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0351594a
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0ef137f5
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@oli-obk
Copy link
Contributor

oli-obk commented Jun 23, 2018

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2018
@bors
Copy link
Collaborator

bors commented Jun 23, 2018

⌛ Testing commit 8ddf9a3 with merge a51e807...

bors added a commit that referenced this pull request Jun 23, 2018
Accept `TyError` in `analyze_closure` to avoid ICE

Fix #51714.
@bors
Copy link
Collaborator

bors commented Jun 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing a51e807 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants