Tweak the raw_identifiers lints in 2018 #52722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @oli-obk |
oli-obk
requested changes
Jul 26, 2018
src/librustc_lint/builtin.rs
Outdated
| @@ -1825,6 +1825,10 @@ impl Async2018 { | |||
| if cx.sess.parse_sess.raw_identifier_spans.borrow().contains(&span) { | |||
| return; | |||
| } | |||
| // Don't suggest about raw identifiers if the feature isn't active | |||
| if !cx.sess.features_untracked().raw_identifiers { | |||
| return | |||
There was a problem hiding this comment.
We can still lint, we should just not have a suggestion in that case, but simply a note about choosing a different name.
* Enable the `raw_identifiers` feature automatically in the 2018 preview * Only emit lint warnings if the `raw_identifiers` feature is activated cc rust-lang/cargo#5783
alexcrichton
force-pushed
the
more-identifier-lints
branch
from
29cd439 to
336cf9d
Compare
|
Updated! |
oli-obk
approved these changes
Jul 30, 2018
|
@bors r+ |
|
📌 Commit 336cf9d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 30, 2018
Tweak the raw_identifiers lints in 2018 * Enable the `raw_identifiers` feature automatically in the 2018 preview * Only emit lint warnings if the `raw_identifiers` feature is activated cc rust-lang/cargo#5783
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raw_identifiersfeature automatically in the 2018 previewraw_identifiersfeature is activatedcc rust-lang/cargo#5783