syntax: Enforce attribute grammar in the parser #53293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
commented
Aug 12, 2018
src/libsyntax/parse/attr.rs
Outdated
| /// PATH `[` TOKEN_STREAM `]` | ||
| /// PATH `{` TOKEN_STREAM `}` | ||
| /// PATH `=` TOKEN_TREE | ||
| /// The delimiters or `=` are still put into the resulting token stream. |
There was a problem hiding this comment.
I initially wanted to store the delimiter and actual tokens separately in ast::Attribute, but that required much larger refactoring, so I left it for later.
petrochenkov
force-pushed
the
gramattr2
branch
from
73eeed7 to
47ba0ef
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors: r+ |
|
📌 Commit 47ba0ef9cc84888249e5f6c828e2925bfd95b37a has been approved by |
bors
added
S-waiting-on-bors
petrochenkov
force-pushed
the
gramattr2
branch
from
47ba0ef to
7fedf5f
Compare
|
@bors r=alexcrichton |
|
📌 Commit 7fedf5f23dccd0dad2080fcfbb4544978ad0efbf has been approved by |
petrochenkov
force-pushed
the
gramattr2
branch
from
7fedf5f to
097c40c
Compare
|
(Rebased again) |
|
📌 Commit 097c40c has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix feature-gating for
unrestricted_attribute_tokensthat was introduced in #53270, but was actually broken.cc #50911