Skip to content

Destabilize the Error::type_id function #60787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2019
Merged

Destabilize the Error::type_id function #60787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c47e2ef
Destabilize the `Error::type_id` function
alexcrichton May 13, 2019
3db667a
add release notes for rust 1.34.2
pietroalbini May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
Version 1.34.2 (2019-05-14)
===========================

* [Destabilize the `Error::type_id` function due to a security
vulnerability][60785]

[60785]: https://github.com/rust-lang/rust/pull/60785

Version 1.34.1 (2019-04-25)
===========================

Expand Down
5 changes: 4 additions & 1 deletion src/libstd/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ pub trait Error: Debug + Display {
fn source(&self) -> Option<&(dyn Error + 'static)> { None }

/// Gets the `TypeId` of `self`
#[stable(feature = "error_type_id", since = "1.34.0")]
#[doc(hidden)]
#[unstable(feature = "error_type_id",
reason = "this is memory unsafe to override in user code",
issue = "60784")]
fn type_id(&self) -> TypeId where Self: 'static {
TypeId::of::<Self>()
}
Expand Down