Allow any string expression to be used with fail. #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold, I forgot to change walk.rs so it breaks with |fail #fmt("%s", s)| right now. |
|
Thanks! Integrated. I took the liberty of squashing these into a single commit to make the history a little neater. This also introduced a minor test failure in compile-fail/fail-simple which I went ahead and fixed. Please always try to ensure that 'make check' runs successfully. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Add structs defined in linux/input.h I was using definitions for these structs from `ioctl` but because @cmr decide to deprecate his crate (and yanked all versions :() I think that `libc` is the best place for them. In original C header, primitive types uses aliases like `__u16` or `__s32`; for now I replaced them with Rust's counterparts but I'm not sure if it is ok, especially because tests were failing for `u64` (`unsigned long long` vs `unsigned long` on x86_64). Also, should I do something special with union in `ff_effect`? I would like also to add all constants form `linux/input.h` and `linux/input-event-codes.h` if this PR will be accepted.
marysaka
pushed a commit
to sunriseos/rust
that referenced
this pull request
Oct 20, 2019
These aren't actually used anywhere yet, but this is likely a first step in any world! Also note that these types are unstable currently.
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
* Upgraded minimum CBMC version to 5.43.0 * Temporarily enabled `brew update` to get the latest CBMC release
GuillaumeGomez
pushed a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 18, 2025
Add success job for all CI workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.