Build compiletest with in-tree libtest #68019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
One thing that I had wanted was to ban non-test use in compile test... But that can be left for the future, I guess. @bors r+ |
|
📌 Commit 51b7044 has been approved by |
bors
added
S-waiting-on-bors
Is there a technical way to do that? Or did you just want a comment in the source? |
|
I was thinking a comment might suffice :) I'm also not sure how much benefit compiletest gets from depending on libtest -- it might be worth trying to just duplicate and minimize the code instead. |
|
OK, there's a comment for you... |
cuviper
force-pushed
the
in-tree-compiletest
branch
from
6d01359 to
686d5f8
Compare
|
Great! Somehow I thought we were using more features (but maybe they've been stabilized since). @bors r+ |
|
📌 Commit 686d5f8 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 9, 2020
…-Simulacrum Build compiletest with in-tree libtest This updates compiletest to build in `Mode::ToolStd`, using the locally-built crates for `std` and especially `test`. This way we're immune to unstable differences in the bootstrap compiler crates, whether that's a prior-release stage0 or a current release local rebuild. Fixes rust-lang#59264. As a minor cleanup, this also removes the unused `llvm_tools` flag.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 10, 2020
…-Simulacrum Build compiletest with in-tree libtest This updates compiletest to build in `Mode::ToolStd`, using the locally-built crates for `std` and especially `test`. This way we're immune to unstable differences in the bootstrap compiler crates, whether that's a prior-release stage0 or a current release local rebuild. Fixes rust-lang#59264. As a minor cleanup, this also removes the unused `llvm_tools` flag.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 10, 2020
…-Simulacrum Build compiletest with in-tree libtest This updates compiletest to build in `Mode::ToolStd`, using the locally-built crates for `std` and especially `test`. This way we're immune to unstable differences in the bootstrap compiler crates, whether that's a prior-release stage0 or a current release local rebuild. Fixes rust-lang#59264. As a minor cleanup, this also removes the unused `llvm_tools` flag.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 10, 2020
…-Simulacrum Build compiletest with in-tree libtest This updates compiletest to build in `Mode::ToolStd`, using the locally-built crates for `std` and especially `test`. This way we're immune to unstable differences in the bootstrap compiler crates, whether that's a prior-release stage0 or a current release local rebuild. Fixes rust-lang#59264. As a minor cleanup, this also removes the unused `llvm_tools` flag.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 10, 2020
…-Simulacrum Build compiletest with in-tree libtest This updates compiletest to build in `Mode::ToolStd`, using the locally-built crates for `std` and especially `test`. This way we're immune to unstable differences in the bootstrap compiler crates, whether that's a prior-release stage0 or a current release local rebuild. Fixes rust-lang#59264. As a minor cleanup, this also removes the unused `llvm_tools` flag.
bors
added a commit
that referenced
this pull request
Jan 10, 2020
Rollup of 8 pull requests Successful merges: - #66045 (Add method Result::into_ok) - #67258 (Introduce `X..`, `..X`, and `..=X` range patterns) - #68014 (Unify output of "variant not found" errors) - #68019 (Build compiletest with in-tree libtest) - #68039 (remove explicit strip-hidden pass from compiler doc generation) - #68050 (Canonicalize rustc_error imports) - #68059 (Allow specifying LLVM args in target specifications) - #68075 (rustbuild: Cleanup book generation) Failed merges: - #68089 (Unstabilize `Vec::remove_item`) r? @ghost
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
Nov 18, 2020
We already set `compiletest` to use the local sysroot in rust-lang#68019, but that missed the configuration for testing `compiletest` itself.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 19, 2020
…=Mark-Simulacrum Make compiletest testing use the local sysroot We already set `compiletest` to use the local sysroot in rust-lang#68019, but that missed the configuration for testing `compiletest` itself.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 19, 2020
…=Mark-Simulacrum Make compiletest testing use the local sysroot We already set `compiletest` to use the local sysroot in rust-lang#68019, but that missed the configuration for testing `compiletest` itself.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 19, 2020
…=Mark-Simulacrum Make compiletest testing use the local sysroot We already set `compiletest` to use the local sysroot in rust-lang#68019, but that missed the configuration for testing `compiletest` itself.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 8, 2025
…t-libtest, r=jieyouxu,kobzol make it possible to use stage0 libtest on compiletest With rust-lang#119899, building the library tree will require a stage 1 compiler. This is because `compiletest` is defined as a `ToolStd` (since rust-lang#68019) in order to use the in-tree library. As a result, rust-lang#119899 makes certain development workflows more difficult as changes on the compiler tree will now require recompiling `compiletest` each time. This PR allows switching `ToolStd` to `ToolBootstrap` with a simple boolean option in `bootstrap.toml` to allow `compiletest` to use the stage 0 `libtest` instead. The changes under `src/ci` are clearly intended to make sure that `compiletest` doesn't break during future bootstrap beta bumps.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Apr 8, 2025
…t-libtest, r=jieyouxu,kobzol make it possible to use stage0 libtest on compiletest With rust-lang#119899, building the library tree will require a stage 1 compiler. This is because `compiletest` is defined as a `ToolStd` (since rust-lang#68019) in order to use the in-tree library. As a result, rust-lang#119899 makes certain development workflows more difficult as changes on the compiler tree will now require recompiling `compiletest` each time. This PR allows switching `ToolStd` to `ToolBootstrap` with a simple boolean option in `bootstrap.toml` to allow `compiletest` to use the stage 0 `libtest` instead. The changes under `src/ci` are clearly intended to make sure that `compiletest` doesn't break during future bootstrap beta bumps.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 8, 2025
Rollup merge of rust-lang#139386 - onur-ozkan:configurable-compiletest-libtest, r=jieyouxu,kobzol make it possible to use stage0 libtest on compiletest With rust-lang#119899, building the library tree will require a stage 1 compiler. This is because `compiletest` is defined as a `ToolStd` (since rust-lang#68019) in order to use the in-tree library. As a result, rust-lang#119899 makes certain development workflows more difficult as changes on the compiler tree will now require recompiling `compiletest` each time. This PR allows switching `ToolStd` to `ToolBootstrap` with a simple boolean option in `bootstrap.toml` to allow `compiletest` to use the stage 0 `libtest` instead. The changes under `src/ci` are clearly intended to make sure that `compiletest` doesn't break during future bootstrap beta bumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates compiletest to build in
Mode::ToolStd, using the locally-built crates forstdand especiallytest. This way we're immune to unstable differences in the bootstrap compiler crates, whether that's a prior-release stage0 or a current release local rebuild. Fixes #59264.As a minor cleanup, this also removes the unused
llvm_toolsflag.