Skip to content

Use a SmallVec for Cache::predecessors. #70876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

Use a SmallVec for Cache::predecessors. #70876

merged 1 commit into from
Apr 8, 2020

Conversation

nnethercote
Copy link
Contributor

This is a very small win.

@nnethercote
Use a SmallVec for Cache::predecessors.
a90661a 
This is a very small win.
@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2020
@nnethercote
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Apr 7, 2020

⌛ Trying commit a90661a with merge 80411967027444dd4a7c3e40676bb96f2fb9429f...

@bors
Copy link
Collaborator

bors commented Apr 7, 2020

☀️ Try build successful - checks-azure
Build commit: 80411967027444dd4a7c3e40676bb96f2fb9429f (80411967027444dd4a7c3e40676bb96f2fb9429f)

@rust-timer
Copy link
Collaborator

Queued 80411967027444dd4a7c3e40676bb96f2fb9429f with parent 209b2be, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit 80411967027444dd4a7c3e40676bb96f2fb9429f, comparison URL.

@nnethercote
Copy link
Contributor Author

A number of small improvements, up to 0.5%. And I checked locally with DHAT, the number of allocations done for webrender-wrench-check-clean (an illustrative example) drops by 2.5%.

@estebank
Copy link
Contributor

estebank commented Apr 8, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 8, 2020

📌 Commit a90661a has been approved by estebank

@bors
Copy link
Collaborator

bors commented Apr 8, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 8, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 8, 2020
@bors
Auto merge of rust-lang#70931 - Dylan-DPC:rollup-f8orcao, r=Dylan-DPC
485c5fb 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#70789 (remove false positives of unused_braces)
 - rust-lang#70847 (ci: move /var/lib/docker to /mnt on GHA)
 - rust-lang#70850 (BTreeMap first last proposal tweaks)
 - rust-lang#70876 (Use a `SmallVec` for `Cache::predecessors`.)
 - rust-lang#70883 (Clean up E0507 explanation)
 - rust-lang#70892 (wf: refactor `compute_trait_ref`)
 - rust-lang#70914 (Corrects a typo in rustdoc documentation.)
 - rust-lang#70915 (Remove unnecessary TypeFlags::NOMINAL_FLAGS)
 - rust-lang#70927 (Clean up E0510 explanation)

Failed merges:

r? @ghost
@bors bors merged commit e97a6e7 into rust-lang:master Apr 8, 2020
@nnethercote nnethercote deleted the smallvec-predecessors branch April 8, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @rust-highfive @rust-timer @bors @estebank