Miri: mplace_access_checked: offer option to force different alignment on place #71280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This was referenced Apr 18, 2020
Merged
oli-obk
reviewed
Apr 22, 2020
| @@ -361,12 +361,14 @@ where | |||
| pub fn mplace_access_checked( | |||
| &self, | |||
| mut place: MPlaceTy<'tcx, M::PointerTag>, | |||
| force_align: Option<Align>, | |||
There was a problem hiding this comment.
please leave a comment on this argument noting that is is only used to allow stacked borrows in miri to handle raw borrows.
|
r=me with the comment added |
|
@bors r=oli-obk |
|
📌 Commit 5449e0f has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#71280 (Miri: mplace_access_checked: offer option to force different alignment on place) - rust-lang#71336 (Exhaustively match on `{Statement,Terminator}Kind` during const checking) - rust-lang#71370 (Added detailed error code explanation for issue E0696 in Rust compiler.) - rust-lang#71401 (visit_place_base is just visit_local) Failed merges: r? @ghost
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Apr 22, 2020
Stacked Borrows: alignment does not matter Fixes #1339 Requires rust-lang/rust#71280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to solve rust-lang/miri#1339 in rust-lang/miri#1348.
r? @oli-obk