-
Notifications
You must be signed in to change notification settings - Fork 13.3k
LVI hardening tests #77008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LVI hardening tests #77008
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
6026a2f
to
e3ae538
Compare
src/test/assembly/x86_64-fortanix-unknown-sgx-lvi-inline-assembly.rs
Outdated
Show resolved
Hide resolved
It looks like some of this is testing C and C++ LVI, as well, which seems a bit out of place for this repository? Could you elaborate why those tests are added? |
The old CMakeLists file of libunwind used the C compiler to compile assembly files. This caused such code not to be hardened.
For the |
e3ae538
to
159d11f
Compare
Okay, I think this is reasonable. It's not too many additional tests and they're SGX only so I'm not too worried in that respect either. @bors r+ rollup=iffy |
📌 Commit 159d11f has been approved by |
⌛ Testing commit 159d11f with merge 032ab1893ec16166331dc85d0b56456bf5442a39... |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-actions |
@bors retry https://github.com/rust-lang-ci/rust/runs/1169263815
|
☀️ Test successful - checks-actions, checks-azure |
Mitigating the speculative execution LVI attack against SGX enclaves requires compiler changes (i.e., adding lfences). This pull requests adds various tests to check if this happens correctly.