Skip to content

replace #[allow_internal_unstable] with #[rustc_allow_const_fn_unstable] for const fns #78208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 25, 2020
Merged

replace #[allow_internal_unstable] with #[rustc_allow_const_fn_unstable] for const fns #78208

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3948b05
add rustc_allow_const_fn_unstable attribute
liketechnik Oct 21, 2020
05f4a9a
switch allow_internal_unstable const fns to rustc_allow_const_fn_unst…
liketechnik Oct 21, 2020
7258740
validate allow_internal_unstable target
liketechnik Oct 21, 2020
3a63bf0
validate rustc_allow_const_fn_unstable targets
liketechnik Oct 21, 2020
83fbddd
ignore #[rustc_allow_const_fn_unstable] for macro expansion
liketechnik Oct 23, 2020
13b481b
rename allow_internal_unstable() to rustc_allow_const_fn_unstable() i…
liketechnik Oct 23, 2020
ac2c599
fix validation for rustc_allow_const_fn_unstable targets
liketechnik Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions compiler/rustc_passes/src/check_attr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ impl CheckAttrVisitor<'tcx> {
self.check_rustc_args_required_const(&attr, span, target, item)
} else if self.tcx.sess.check_name(attr, sym::allow_internal_unstable) {
self.check_allow_internal_unstable(&attr, span, target, &attrs)
} else if self.tcx.sess.check_name(attr, sym::rustc_allow_const_fn_unstable) {
self.check_rustc_allow_const_fn_unstable(&attr, span, target)
} else {
// lint-only checks
if self.tcx.sess.check_name(attr, sym::cold) {
Expand Down Expand Up @@ -791,6 +793,26 @@ impl CheckAttrVisitor<'tcx> {
.emit();
false
}

/// Outputs an error for `#[allow_internal_unstable]` which can only be applied to macros.
/// (Allows proc_macro functions)
fn check_rustc_allow_const_fn_unstable(
&self,
attr: &Attribute,
span: &Span,
target: Target,
) -> bool {
if let Target::Fn | Target::Method(_) = target {
// FIXME Check that this isn't just a function, but a const fn
return true;
}
self.tcx
.sess
.struct_span_err(attr.span, "attribute should be applied to `const fn`")
.span_label(*span, "not a `const fn`")
.emit();
false
}
}

impl Visitor<'tcx> for CheckAttrVisitor<'tcx> {
Expand Down