Code

Update Clippy#78774

Code

Merged

bors merged 107 commits intorust-lang:masterrust-lang/rust:masterfrom

flip1995:clippyupflip1995/rust:clippyupCopy head branch name to clipboard

Nov 5, 2020

Commits

Commits on Oct 15, 2020

• Lint items after statements in macro expansions

  Show description for 32e2021
  achris

  committed
  32e2021

  Copy full SHA for 32e2021

Commits on Oct 25, 2020

• Initial implementation of comparison_to_empty

  Urcra

  committed
  de5a6d3

  Copy full SHA for de5a6d3

• Move implementation into len_zero.rs

  Urcra

  committed
  7f7faa1

  Copy full SHA for 7f7faa1

• Revert changes to Cargo.toml file

  Urcra

  committed
  4417af8

  Copy full SHA for 4417af8

Commits on Oct 26, 2020

• Add description to lint

  Urcra

  committed
  deecfb5

  Copy full SHA for deecfb5

• Run update lints

  Urcra

  committed
  4cf5b5f

  Copy full SHA for 4cf5b5f

• run cargo fmt

  Urcra

  committed
  4532dd9

  Copy full SHA for 4532dd9

• Remove unnecesary format

  Urcra

  committed
  45aa3ef

  Copy full SHA for 45aa3ef

• Add lint for replacing `.map().collect()` with `.try_for_each()`

  HMPerson1

  committed
  f0cf3bd

  Copy full SHA for f0cf3bd

• No lint in external macro for `toplevel_ref_arg`

  ThibsG

  committed
  bab3386

  Copy full SHA for bab3386

• Use better placeholders for some methods lint messages

  ThibsG

  committed
  2911d9c

  Copy full SHA for 2911d9c

• Improve some suggestions for `filter_map_next`, `filter_next` and `map_unwrap_or` lints

  ThibsG

  committed
  3fec6f5

  Copy full SHA for 3fec6f5

• Move fixable `map_unwrap_or` cases to rustfixed test

  ThibsG

  committed
  2a3ae11

  Copy full SHA for 2a3ae11

• Move fixable `filter_next` and `filter_map_next` cases to rustfixed tests

  ThibsG

  committed
  e2d86b5

  Copy full SHA for e2d86b5

• Fix tests for `map_unwrap_or*`

  ThibsG

  committed
  c0dd1f9

  Copy full SHA for c0dd1f9

• clippy_lint: Add 'ref_option_ref'

  dvermd

  committed
  213dbf7

  Copy full SHA for 213dbf7

• clippy_lint: Add 'ref_option_ref' refactor code

  dvermd

  committed
  d1baa25

  Copy full SHA for d1baa25

• clippy_lint: Add 'ref_option_ref' move to check_ty and add type alias test

  dvermd

  committed
  469b2fc

  Copy full SHA for 469b2fc

• clippy_lint: Add 'ref_option_ref' remove unused import

  dvermd

  committed
  c1f3bab

  Copy full SHA for c1f3bab

• clippy_lint: Allow 'ref_option_ref' for 'option_if_let_else'

  dvermd

  committed
  bdd76a9

  Copy full SHA for bdd76a9

• clippy_lint: Refactor 'ref_option_ref'

  dvermd

  committed
  b41b38c

  Copy full SHA for b41b38c

• clippy_lint: Add test cases

  dvermd

  committed
  2270ff4

  Copy full SHA for 2270ff4

• Update clippy_lints/src/ref_option_ref.rs doctest

  Show description for 8e26004
  

  dvermd

  and

  flip1995

  committed
  8e26004

  Copy full SHA for 8e26004

• Update clippy_lints/src/ref_option_ref.rs

  Show description for 1566db7
  

  dvermd

  and

  flip1995

  committed
  1566db7

  Copy full SHA for 1566db7

• clippy_lint: Add Known Problems message

  dvermd

  committed
  7fd74c6

  Copy full SHA for 7fd74c6

• Update clippy_lints/src/ref_option_ref.rs

  Show description for db40a07
  

  dvermd

  and

  flip1995

  committed
  db40a07

  Copy full SHA for db40a07

• clippy_lint: run after changing category to pendantic

  dvermd

  committed
  ffddb66

  Copy full SHA for ffddb66

• Change Applicability to MaybeIncorrect

  Show description for 8337c46
  

  dvermd

  and

  flip1995

  committed
  8337c46

  Copy full SHA for 8337c46

• Explain why 'run-rustfix' is not defined

  dvermd

  committed
  6212950

  Copy full SHA for 6212950

• fix the error-causing suggestion of 'borrowed_box'

  Show description for e568a32
  rail-rain

  committed
  e568a32

  Copy full SHA for e568a32

Commits on Oct 27, 2020

• add manual_ok_or lint

  tnielens

  committed
  111b902

  Copy full SHA for 111b902

• Replace `E-easy` with `good first issue` in `CONTRIBUTING.md`

  Show description for 8bd1e23
  giraffate

  committed
  8bd1e23

  Copy full SHA for 8bd1e23

Commits on Oct 28, 2020

• Fix suggestion to add unneeded space in `unused_unit`

  giraffate

  committed
  4c58860

  Copy full SHA for 4c58860

• use diff -u in driver.sh test

  Show description for 0d6eed1
  matthiaskrgr

  committed
  0d6eed1

  Copy full SHA for 0d6eed1

• Auto merge of #6263 - matthiaskrgr:diff_u, r=ebroto

  Show description for 4f1240f
  bors

  committed
  4f1240f

  Copy full SHA for 4f1240f

• add a couple of ICE testcases

  Show description for abd64d7
  matthiaskrgr

  committed
  abd64d7

  Copy full SHA for abd64d7

• Merge commit '645ef505da378b6f810b1567806d1bcc2856395f' into clippyup

  ebroto

  committed
  5041911

  Copy full SHA for 5041911

Commits on Oct 29, 2020

• cargo dev ra-setup: don't inject deps multiple times if we have already done so

  Show description for 7f3462a
  matthiaskrgr

  committed
  7f3462a

  Copy full SHA for 7f3462a

• Auto merge of #6264 - matthiaskrgr:ra_setup_no_twice, r=llogiq

  Show description for 6d5cd6e
  bors

  committed
  6d5cd6e

  Copy full SHA for 6d5cd6e

• Update existing arithmetic lint and add new tests related to it.

  henil

  committed
  e97602e

  Copy full SHA for e97602e

• Auto merge of #6212 - ThibsG:MacroTopLevelRefArg, r=flip1995

  Show description for e8de57c
  bors

  committed
  e8de57c

  Copy full SHA for e8de57c

• Remove empty lines in doc comment

  Show description for e3de544
  

  Urcra

  and

  flip1995

  authored
  e3de544

  Copy full SHA for e3de544

• Auto merge of #6176 - achris:issues/578, r=phansch

  Show description for ee9da9a
  bors

  committed
  ee9da9a

  Copy full SHA for ee9da9a

• Auto merge of #6226 - Urcra:master, r=flip1995

  Show description for e1a2845
  bors

  committed
  e1a2845

  Copy full SHA for e1a2845

• Update CONTRIBUTING.md to describe `E-medium` in detail

  Show description for 38ec920
  

  giraffate

  and

  flip1995

  authored
  38ec920

  Copy full SHA for 38ec920

• Auto merge of #6227 - HMPerson1:collect_map, r=phansch

  Show description for c57d8ae
  bors

  committed
  c57d8ae

  Copy full SHA for c57d8ae

• Auto merge of #6248 - giraffate:replace_e_easy_with_good_first_issue, r=flip1995

  Show description for e01d487
  bors

  committed
  e01d487

  Copy full SHA for e01d487

• Update clippy_lints/src/ref_option_ref.rs

  Show description for 230d9cb
  

  dvermd

  and

  flip1995

  authored
  230d9cb

  Copy full SHA for 230d9cb

• clippy: update reference file to match suggested change

  dvermd

  committed
  7b065db

  Copy full SHA for 7b065db

• add manual_ok_or / pr remarks

  tnielens

  committed
  d780f61

  Copy full SHA for d780f61

Commits on Oct 30, 2020

• Auto merge of #6200 - rail-rain:borrowed_box_invalid_sugg, r=phansch

  Show description for 74d8fbb
  bors

  committed
  74d8fbb

  Copy full SHA for 74d8fbb

• TypeVisitor: use `ControlFlow` in clippy

  LeSeulArtichaut

  committed
  fa79cc4

  Copy full SHA for fa79cc4

• Use `ControlFlow::is{break,continue}`

  LeSeulArtichaut

  committed
  4a06145

  Copy full SHA for 4a06145

• Remove implicit `Continue` type

  LeSeulArtichaut

  committed
  1c8c3d1

  Copy full SHA for 1c8c3d1

• removed lint for division/modulo for literal `0`

  henil

  committed
  fa0a78b

  Copy full SHA for fa0a78b

• Auto merge of #6229 - henil:improve-integer-division-lint, r=phansch

  Show description for 0be6544
  bors

  committed
  0be6544

  Copy full SHA for 0be6544

• Clarify allow/warn/deny. Remove enable/disable.

  Show description for 9f402c9
  ClashTheBunny

  committed
  9f402c9

  Copy full SHA for 9f402c9

• Auto merge of #6197 - ThibsG:ImproveFilterNext, r=ebroto

  Show description for 7387b87
  bors

  committed
  7387b87

  Copy full SHA for 7387b87

• Auto merge of #6260 - matthiaskrgr:ices, r=ebroto

  Show description for 084b203
  bors

  committed
  084b203

  Copy full SHA for 084b203

• single_char_push_str lint using insert_str() on single-char literals and suggest insert()

  Show description for 2350ee7
  

  matthiaskrgr

  authored and

  ebroto

  committed
  2350ee7

  Copy full SHA for 2350ee7

• handle macros returning Strings in single_char_push_str and single_char_insert_str

  

  matthiaskrgr

  authored and

  ebroto

  committed
  c6412ae

  Copy full SHA for c6412ae

• get_hint_if_single_char_arg: fix bug where multi-char letters are not detected properly

  

  matthiaskrgr

  authored and

  ebroto

  committed
  c1eb8ce

  Copy full SHA for c1eb8ce

• Rename single_char_push_str to single_char_add_str

  ebroto

  committed
  d958269

  Copy full SHA for d958269

• Address suggestions in PR review

  ebroto

  committed
  f8ac1f9

  Copy full SHA for f8ac1f9

Commits on Oct 31, 2020

• Update Clippy path to `Lint`

  Aaron1011

  committed
  4bbc771

  Copy full SHA for 4bbc771

• Merge remote-tracking branch 'upstream/master' into rustup

  ebroto

  committed
  9d73371

  Copy full SHA for 9d73371

• Fix formatting

  ebroto

  committed
  2eb248d

  Copy full SHA for 2eb248d

• Auto merge of #6277 - ebroto:rustup, r=ebroto

  Show description for a6b3a40
  bors

  committed
  a6b3a40

  Copy full SHA for a6b3a40

• Fix typo in adding_lints.md

  dp304

  committed
  edfa13d

  Copy full SHA for edfa13d

• Auto merge of #6276 - dp304:patch-1, r=llogiq

  Show description for e298c83
  bors

  committed
  e298c83

  Copy full SHA for e298c83

• Implement field_reassign_with_default

  Show description for 7b203f3
  

  Henri Lunnikivi

  authored and

  hegza

  committed
  7b203f3

  Copy full SHA for 7b203f3

Commits on Nov 1, 2020

• Auto merge of #75534 - Aaron1011:feature/new-future-breakage, r=pnkfelix

  Show description for 8a18963
  bors

  committed
  8a18963

  Copy full SHA for 8a18963

Commits on Nov 2, 2020

• Merge remote-tracking branch 'upstream/master' into sync-from-rust

  giraffate

  committed
  4a3a249

  Copy full SHA for 4a3a249

• Provide diagnostic suggestion in ExprUseVisitor Delegate

  Show description for 5f97326
  null-sleep

  committed
  5f97326

  Copy full SHA for 5f97326

• Auto merge of #6282 - giraffate:sync-from-rust, r=ebroto

  Show description for c45255b
  bors

  committed
  c45255b

  Copy full SHA for c45255b

• Use const rustc sym where possible

  camsteffen

  committed
  22cc77a

  Copy full SHA for 22cc77a

• Change lint to use const sym

  camsteffen

  committed
  b2332a7

  Copy full SHA for b2332a7

Commits on Nov 3, 2020

• Auto merge of #6037 - matthiaskrgr:single_char_insert, r=flip1995

  Show description for 3ee9c2e
  bors

  committed
  3ee9c2e

  Copy full SHA for 3ee9c2e

• Add `from_iter_instead_of_collect` lint implementation

  

  pitiK3U

  authored and

  flip1995

  committed
  315bab0

  Copy full SHA for 315bab0

• Run `cargo dev update_lints`

  

  pitiK3U

  authored and

  flip1995

  committed
  9d6eedf

  Copy full SHA for 9d6eedf

• Add tests for `from_iter_instead_of_collect`

  

  pitiK3U

  authored and

  flip1995

  committed
  1b117f4

  Copy full SHA for 1b117f4

• Fix `from_iter_instead_of_collect` lint crashing on exprs without path segment

  

  pitiK3U

  authored and

  flip1995

  committed
  8a5d78b

  Copy full SHA for 8a5d78b

• Update: stderr message format

  

  pitiK3U

  authored and

  flip1995

  committed
  a856706

  Copy full SHA for a856706

• Improvements from PR feedback

  

  pitiK3U

  authored and

  flip1995

  committed
  8906040

  Copy full SHA for 8906040

• Allow lint

  

  pitiK3U

  authored and

  flip1995

  committed
  0ab96ba

  Copy full SHA for 0ab96ba

• Improve: error message

  

  pitiK3U

  authored and

  flip1995

  committed
  e320dd3

  Copy full SHA for e320dd3

• Run `cargo dev fmt`

  

  pitiK3U

  authored and

  flip1995

  committed
  854f2ce

  Copy full SHA for 854f2ce

• Remove backticks

  

  pitiK3U

  authored and

  flip1995

  committed
  abdb7ae

  Copy full SHA for abdb7ae

• Improve error message

  

  pitiK3U

  authored and

  flip1995

  committed
  f359fb8

  Copy full SHA for f359fb8

• Fix: Don't show lint for types that doesn't implement Iterator

  

  pitiK3U

  authored and

  flip1995

  committed
  52d1ea3

  Copy full SHA for 52d1ea3

• Fix: Use `.collect()` instead of `::fromIterator()`

  

  pitiK3U

  authored and

  flip1995

  committed
  ddf23d6

  Copy full SHA for ddf23d6

• Auto merge of #6101 - pitiK3U:from_iter_instead_of_collect, r=flip1995

  Show description for a2bf404
  bors

  committed
  a2bf404

  Copy full SHA for a2bf404

• Auto merge of #6165 - dvermd:ref_option_ref, r=flip1995

  Show description for 2fe87a8
  bors

  committed
  2fe87a8

  Copy full SHA for 2fe87a8

• Auto merge of #6233 - montrivo:manual_ok_or, r=flip1995

  Show description for 225ce5f
  bors

  committed
  225ce5f

  Copy full SHA for 225ce5f

• Update wording to avoid code having "lint" metaphor

  ClashTheBunny

  committed
  cf2043d

  Copy full SHA for cf2043d

Commits on Nov 4, 2020

• Auto merge of #6270 - ClashTheBunny:clarify_allow_deny_enable_disable, r=flip1995

  Show description for 3a34bc0
  bors

  committed
  3a34bc0

  Copy full SHA for 3a34bc0

• Auto merge of #6284 - camsteffen:rustc-sym, r=flip1995

  Show description for c2cf40c
  bors

  committed
  c2cf40c

  Copy full SHA for c2cf40c

• Split the "raw integer bytes" part out of `Scalar`

  oli-obk

  committed
  6fdbde5

  Copy full SHA for 6fdbde5

• s/Scalar::Raw/Scalar::Int

  oli-obk

  committed
  83edb2f

  Copy full SHA for 83edb2f

• Merge remote-tracking branch 'upstream/master' into rustup

  ebroto

  committed
  834ad5c

  Copy full SHA for 834ad5c

• Run cargo dev fmt

  ebroto

  committed
  f5166e8

  Copy full SHA for f5166e8

• Auto merge of #6292 - ebroto:rustup, r=ebroto

  Show description for 62c0d29
  bors

  committed
  62c0d29

  Copy full SHA for 62c0d29

• Auto merge of #5911 - hegza:issue-568, r=ebroto

  Show description for 5b52474
  bors

  committed
  5b52474

  Copy full SHA for 5b52474

• Auto merge of #6247 - giraffate:fix_suggestion_to_add_space_in_unused_unit, r=ebroto

  Show description for 0d2f1ae
  bors

  committed
  0d2f1ae

  Copy full SHA for 0d2f1ae

• Auto merge of #78662 - sexxi-goose:add_expr_id_to_delegate, r=nikomatsakis

  Show description for 0c1531a
  bors

  committed
  0c1531a

  Copy full SHA for 0c1531a

Commits on Nov 5, 2020

• Auto merge of #6296 - flip1995:rustup, r=flip1995

  Show description for b20d4c1
  bors

  committed
  b20d4c1

  Copy full SHA for b20d4c1

• Merge commit 'b20d4c155d2fe3a8391f86dcf9a8c49e17188703' into clippyup

  flip1995

  committed
  46c714f

  Copy full SHA for 46c714f