Skip to content

Add #[cold] attribute to std::process::abort and alloc::alloc::handle_alloc_error #79172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2020
Merged

Add #[cold] attribute to std::process::abort and alloc::alloc::handle_alloc_error #79172

merged 1 commit into from
Nov 23, 2020

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Nov 18, 2020

No description provided.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 18, 2020
@jyn514 jyn514 added A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows I-slow Issue: Problems and improvements with respect to performance of generated code. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 18, 2020
@Mark-Simulacrum
Copy link
Member

I sort of doubt this'll end up having any major effect -- I would expect LLVM to already consider diverging code paths pretty cold -- but it seems like a reasonable change. @bors r+ rollup=never so we note perf effects (if any).

@bors
Copy link
Collaborator

bors commented Nov 19, 2020

📌 Commit b4c91f9 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2020
@bors
Copy link
Collaborator

bors commented Nov 19, 2020

⌛ Testing commit b4c91f9 with merge 0386c38f89e73a656239978d3220369b1503f2ed...

@bors
Copy link
Collaborator

bors commented Nov 19, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 19, 2020
@a1phyr
Copy link
Contributor Author

a1phyr commented Nov 21, 2020

The failed test is literally exit 1. How am I supposed to fix it ?

@Mark-Simulacrum
Copy link
Member

@bors retry - apple builders were canceled? ("The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.")

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
@bors
Copy link
Collaborator

bors commented Nov 23, 2020

⌛ Testing commit b4c91f9 with merge f32459c...

@bors
Copy link
Collaborator

bors commented Nov 23, 2020

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f32459c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 23, 2020
@bors bors merged commit f32459c into rust-lang:master Nov 23, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 23, 2020
@a1phyr a1phyr deleted the cold_abort branch March 12, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows I-slow Issue: Problems and improvements with respect to performance of generated code. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@a1phyr @rust-highfive @Mark-Simulacrum @bors @jyn514 @rustbot