-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Backport some LLVM compile-time improvements #82783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 3081eafd4373baf97ec55b1d97174714e5cf9ba2 with merge 57645773c360978a7ca9935c2c58f8394fc97e0a... |
☀️ Try build successful - checks-actions |
Queued 57645773c360978a7ca9935c2c58f8394fc97e0a with parent 45b3c28, future comparison URL. |
Finished benchmarking try commit (57645773c360978a7ca9935c2c58f8394fc97e0a): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Minor improvements to opt builds and a 1.5% improvement on bootstrap. r? @nagisa Does this seems worthwhile? If so, I'll push this to the branch and update the submodule reference. |
This does seem quite worthwhile yes. I'm comfortable with the LICM changes, since they have been landed upstream, but I wasn't able to find the diffs or commits corresponding to the |
@nagisa The upstream commits are llvm/llvm-project@7c706aa, llvm/llvm-project@e0615bc, llvm/llvm-project@3d8f842, llvm/llvm-project@29034f3. I should get into the habit of using |
Yeah LGTM then, r=me once these commits end up in a proper branch. |
This backports two compile-time improvements from the LLVM 13 branch, which reduce the number of alias analysis queries.
@bors r=nagisa |
📌 Commit c484bfe has been approved by |
☀️ Test successful - checks-actions |
This seems to have fixed some performance regressions (perhaps with the help of other things in the last week) introduced by LLVM12. |
Pick up two LLVM patches that reduce number of alias analysis queries, to see whether that gives any visible improvement.
r? @ghost