Skip to content

Provide a suggestion when trying to destructure a Vec as a slice #87033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2021
Merged

Provide a suggestion when trying to destructure a Vec as a slice #87033

merged 2 commits into from
Aug 3, 2021

Conversation

FabianWolff
Copy link
Contributor

Fixes #87017.

r? @estebank

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2021
camsteffen
camsteffen reviewed Jul 26, 2021
View reviewed changes
estebank
estebank reviewed Aug 2, 2021
View reviewed changes
@estebank
Copy link
Contributor

estebank commented Aug 2, 2021

r=me after applying the change (and re-running --bless to generate the .fixed file)

@FabianWolff
Copy link
Contributor Author

r=me after applying the change (and re-running --bless to generate the .fixed file)

This is ready to be merged. Thanks for the review @estebank!

@estebank
Copy link
Contributor

estebank commented Aug 3, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 3, 2021

📌 Commit 7b26f76 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2021
@bors
Copy link
Collaborator

bors commented Aug 3, 2021

⌛ Testing commit 7b26f76 with merge 3354a44...

@bors
Copy link
Collaborator

bors commented Aug 3, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 3354a44 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 3, 2021
@bors bors merged commit 3354a44 into rust-lang:master Aug 3, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

@camsteffen camsteffen camsteffen left review comments

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

When trying to destructure a Vec as a slice provide a suggestion
7 participants
@FabianWolff @estebank @bors @camsteffen @JohnCSimon @rust-highfive @rustbot