-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Doctest persist full binaries when persisting #88269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/test/run-make-fulldeps/doctests-keep-binaries/Makefile
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
include ../../run-make-fulldeps/tools.mk | ||
|
||
# Check that valid binaries are persisted by running them, regardless of whether the --run or --no-run option is used. | ||
|
||
all: run no_run | ||
|
||
run: | ||
mkdir -p $(TMPDIR)/doctests | ||
$(RUSTC) --crate-type rlib t.rs | ||
$(RUSTDOC) -Zunstable-options --test --persist-doctests $(TMPDIR)/doctests --extern t=$(TMPDIR)/libt.rlib t.rs | ||
$(TMPDIR)/doctests/t_rs_2_0/rust_out | ||
$(TMPDIR)/doctests/t_rs_8_0/rust_out | ||
rm -rf $(TMPDIR)/doctests | ||
|
||
no_run: | ||
mkdir -p $(TMPDIR)/doctests | ||
$(RUSTC) --crate-type rlib t.rs | ||
$(RUSTDOC) -Zunstable-options --test --persist-doctests $(TMPDIR)/doctests --extern t=$(TMPDIR)/libt.rlib t.rs --no-run | ||
$(TMPDIR)/doctests/t_rs_2_0/rust_out | ||
$(TMPDIR)/doctests/t_rs_8_0/rust_out | ||
rm -rf $(TMPDIR)/doctests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/// Fungle the foople. | ||
/// ``` | ||
/// t::foople(); | ||
/// ``` | ||
pub fn foople() {} | ||
|
||
/// Flomble the florp | ||
/// ``` | ||
/// t::florp(); | ||
/// ``` | ||
pub fn florp() {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may cause some minor divergence in behavior depending on whether
--persist-doctests
is run, for the same reason thecompile_fail
clause was added earlier. I don't have any perspective whether that's ok.