Skip to content

Move global analyses from lowering to resolution #88597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 3, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Sep 2, 2021

Split off #87234

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 2, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 2, 2021
@bors
Copy link
Collaborator

bors commented Sep 2, 2021

⌛ Trying commit f8efe5d with merge 55a2679034dcd10e43a84a540a604d67e8e26cbe...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Sep 2, 2021

☀️ Try build successful - checks-actions
Build commit: 55a2679034dcd10e43a84a540a604d67e8e26cbe (55a2679034dcd10e43a84a540a604d67e8e26cbe)

@rust-timer
Copy link
Collaborator

Queued 55a2679034dcd10e43a84a540a604d67e8e26cbe with parent fcce644, future comparison URL.

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (55a2679034dcd10e43a84a540a604d67e8e26cbe): comparison url.

Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.

  • Moderate improvement in instruction counts (up to -1.6% on incr-unchanged builds of keccak)
  • Small regression in instruction counts (up to 0.6% on full builds of deep-vector)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 2, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 3, 2021

📌 Commit 5e3cd6a has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2021
@bors
Copy link
Collaborator

bors commented Sep 3, 2021

⌛ Testing commit 5e3cd6a with merge 577a76f...

@bors
Copy link
Collaborator

bors commented Sep 3, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 577a76f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2021
@bors bors merged commit 577a76f into rust-lang:master Sep 3, 2021
@rustbot rustbot added this to the 1.56.0 milestone Sep 3, 2021
@pnkfelix
Copy link
Member

pnkfelix commented Sep 8, 2021

This was identified as yielding a moderate improvement in instruction counts (up to -1.6% on incr-unchanged builds of keccak) during weekly performance triage. Thanks and good job! 🎉

@Mark-Simulacrum
Copy link
Member

Small regressions are limited to stress tests -- marking as triaged, the benefits here outweigh the relatively small regressions.

@Mark-Simulacrum Mark-Simulacrum added the perf-regression-triaged The performance regression has been triaged. label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants