-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Move global analyses from lowering to resolution #88597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The definition order is already close to the span order, and only differs in corner cases.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit f8efe5d with merge 55a2679034dcd10e43a84a540a604d67e8e26cbe... |
This comment has been minimized.
This comment has been minimized.
☀️ Try build successful - checks-actions |
Queued 55a2679034dcd10e43a84a540a604d67e8e26cbe with parent fcce644, future comparison URL. |
Finished benchmarking try commit (55a2679034dcd10e43a84a540a604d67e8e26cbe): comparison url. Summary: This change led to moderate relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @bors rollup=never |
@bors r+ |
📌 Commit 5e3cd6a has been approved by |
☀️ Test successful - checks-actions |
This was identified as yielding a moderate improvement in instruction counts (up to -1.6% on |
Small regressions are limited to stress tests -- marking as triaged, the benefits here outweigh the relatively small regressions. |
Split off #87234
r? @petrochenkov