libstd/os: set tmp dir to /data/tmp on Android #8901
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could probably be written as (which helps reduce the ugliness of the conditional compilation): #[cfg(unix)]
fn lookup() -> Path {
if cfg!(target_os = "android") {
Path("/data/tmp")
} else {
getenv_nonempty("TMPDIR").unwrap_or_default(Path("/tmp"))
}
}(The |
| Path("/data/tmp") | ||
| } else { | ||
| getenv_nonempty("TMPDIR").unwrap_or_default(Path("/tmp")) | ||
| } |
There was a problem hiding this comment.
The build log says that the build failed because there is trailing whitespace on this line.
There was a problem hiding this comment.
My bad, I shouldn't have copy-pasted that and since the build system was a bit flaky recently I thought it was a false positive.
Android has no /tmp partition, return /data/tmp instead. Cf. rust-lang#8511.
bors
added a commit
that referenced
this pull request
Sep 4, 2013
Android has no /tmp partition, cf. #8511.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 16, 2022
Rework `branches_sharing_code` fixes rust-lang#7378 This changes the lint from checking pairs of blocks, to checking all the blocks at the same time. As such there's almost none of the original code left. changelog: Don't lint `branches_sharing_code` when using different binding names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android has no /tmp partition, cf. #8511.